feat: dummy snark should have correct agg_vkey_hash
#51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for the keygen script for a universal aggregation circuit to compute the correct agg_vkey_hash, it must read any previous agg_vkey_hash's from the public instances of dependency snarks. Therefore dummy dependency snarks should not have all instances 0: the instance that holds that agg_vkey_hash needs to be set correctly.